Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase font sizes on all themes #2352

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

iatenine
Copy link
Contributor

@iatenine iatenine commented Feb 4, 2024

Description

Set themes to not decrease font size by default
Fixes #2351

Screenshots

Before

Screenshot from 2024-02-03 22-39-09

After

Screenshot from 2024-02-03 22-40-26

Admittedly it's a small difference the screenshots struggle to capture but one I can feel in a reduction of eye strain

Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS files are auto-generated. You're gonna have to update the SCSS files for the themes, then run yarn themes:build to generate the CSS.

@iatenine
Copy link
Contributor Author

iatenine commented Feb 4, 2024

The CSS files are auto-generated. You're gonna have to update the SCSS files for the themes, then run yarn themes:build to generate the CSS.

Thanks, I tend to forget direct CSS manipulation has become so rare and was struggling to get a local build running to test for sure but both of these issues have been fixed now

port 1234 (left) is with new theme builds, 1236/right is the lemmy-ui Docker image
Screenshot from 2024-02-04 11-53-14

Different theme
Screenshot from 2024-02-04 12-04-55

mobile
Screenshot from 2024-02-04 12-05-19

comments section
Screenshot from 2024-02-04 12-05-48

and, well, I'm sure you get the idea... Lots of places to check to see if font sizes have broken the layout but I'm not seeing any so far

@SleeplessOne1917 SleeplessOne1917 merged commit ae5a281 into LemmyNet:main Feb 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase root-font-size to 100% on all themes and (for darkly-pureblack) body font size to 1rem
2 participants